Skip to content

fix: missing value on NetworkListEvent for EventType.RemoveAt events server side (#2542)#2543

Closed
PitouGames wants to merge 2 commits intoUnity-Technologies:developfrom
PitouGames:fix/2542
Closed

fix: missing value on NetworkListEvent for EventType.RemoveAt events server side (#2542)#2543
PitouGames wants to merge 2 commits intoUnity-Technologies:developfrom
PitouGames:fix/2542

Conversation

@PitouGames
Copy link
Copy Markdown
Contributor

@PitouGames PitouGames commented May 1, 2023

Resolve #2542

This PR adds the value on NetworkListEvent for EventType.RemoveAt events server side.
The code for server is now the same as in ReadDelta function used by the client.

Changelog

Testing and Documentation

  • No tests have been added, but could be great to add one that check the value for each possible opertations (add, insert, modify value, remove, removeAt, clear) on NetworkList.
  • No documentation changes or additions are necessary.

@PitouGames PitouGames requested a review from a team as a code owner May 1, 2023 13:49
@0xFA11 0xFA11 requested a review from jeffreyrainy May 1, 2023 16:26
@NoelStephensUnity
Copy link
Copy Markdown
Member

NoelStephensUnity commented May 12, 2023

@PitouGames
Thank you for your contribution!
Your PR was cherry picked into an upstream branch and the new PR is #2559.
I will update the changelog entry slightly and create a test to validate the changes.
👍

@NoelStephensUnity
Copy link
Copy Markdown
Member

NoelStephensUnity commented May 12, 2023

Accepted and Implemented in #2559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffreyrainy jeffreyrainy Awaiting requested review from jeffreyrainy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NetworkListEvent miss value for EventType.RemoveAt events server side

2 participants

@PitouGames @NoelStephensUnity